Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

From: Cyrill Gorcunov
Date: Thu Sep 15 2016 - 16:22:32 EST


On Thu, Sep 15, 2016 at 01:53:13PM -0600, David Ahern wrote:
> On 9/13/16 11:19 AM, Cyrill Gorcunov wrote:
> > In criu we are actively using diag interface to collect sockets
> > present in the system when dumping applications. And while for
> > unix, tcp, udp[lite], packet, netlink it works as expected,
> > the raw sockets do not have. Thus add it.
> >
> > v2:
> > - add missing sock_put calls in raw_diag_dump_one (by eric.dumazet@)
> > - implement @destroy for diag requests (by dsa@)
> >
> > v3:
> > - add export of raw_abort for IPv6 (by dsa@)
> > - pass net-admin flag into inet_sk_diag_fill due to
> > changes in net-next branch (by dsa@)
> >
> > CC: David S. Miller <davem@xxxxxxxxxxxxx>
> > CC: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> > CC: David Ahern <dsa@xxxxxxxxxxxxxxxxxxx>
> > CC: Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>
> > CC: James Morris <jmorris@xxxxxxxxx>
> > CC: Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>
> > CC: Patrick McHardy <kaber@xxxxxxxxx>
> > CC: Andrey Vagin <avagin@xxxxxxxxxx>
> > CC: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
> > ---
>
> ss -K is not working. Socket lookup fails to find a match due to a protocol mismatch.
>
> haven't had time to track down why there is a mismatch since the kill uses the socket returned
> from the dump. Won't have time to come back to this until early next week.

Have you ran iproute2 patched? I just ran ss -K and all sockets get closed
(including raw ones), which actually kicked me off the testing machine sshd :/

Cyrill