Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"
From: Joe Perches
Date: Sat Sep 24 2016 - 13:03:20 EST
On Sat, 2016-09-24 at 18:55 +0200, SF Markus Elfring wrote:
> > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > Why did you split it off from the patch where you attempt to use it?
> I chose a special patch granularity once again.
> > What good does this change do on its own?
> I find that it is a preparation. - If this addition could not be accepted,
> the following update step would also be discussed under an other perspective,
> wouldn't it?
It's purposeless, creates unnecessary patches to review
and generally wastes other people's time.
Please don't purposefully waste other people's time.
It makes your patch proposals _less_ likely to be applied.