Re: [PATCH 3/5] ISDN-CAPI: Adjust 17 function calls together with variable assignments
From: Paul Bolle
Date: Mon Sep 26 2016 - 05:13:06 EST
On Sun, 2016-09-25 at 13:13 +0200, SF Markus Elfring wrote:
> The script "checkpatch.pl" can point out that assignments should usually
> not be performed within condition checks.
> Thus move the assignment for a variable to a separate statement
> in four functions.
Did you recycle this commit explanation? Because git diff tells me you
actually touched about eight functions. Â
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Âdrivers/isdn/capi/capidrv.c | 59 +++++++++++++++++++++++++++------------------
> Â1 file changed, 36 insertions(+), 23 deletions(-)
So I ran checkpatch on this file, just like you did. Specifically, I
Âscripts/checkpatch.pl -f drivers/isdn/capi/capidrv.c | grep "assignment in if condition" | wc -lÂ
It tells me there are actually 18 instances of this "ERROR". Why did
you ignore one of it in this patch?