Re: [PATCH] mos7840: fix chars_in_buffer() return value
From: Johan Hovold
Date: Thu Sep 29 2016 - 06:09:50 EST
On Sat, Sep 24, 2016 at 06:00:57PM +0300, Stas Sergeev wrote:
> The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on
> a correct behaviour of that.
> mos7840 implements it wrongly: if you write just one char, TIOCOUTQ
> will return 32.
> This patch should fix it by accounting the number of chars actually
> This patch, unfortunately, misses the Tested-by tag.
> The reporter didn't test it, and I don't have the hardware in question.
Why do you think the driver returns 32b in chars_in_buffer after writing
a single character?
As far as I can see, the driver correctly sums up the outstanding bytes
in its queue (represented by the submitted URBs). There is a tiny window
where the count may be a little off due to the write() implementation
claiming the URB before initialising it, but I'm not sure anyone cares.
But specifically, if you write just one character, TIOCOUTQ does indeed
return a correct count.
Also note that your patch would break the driver in case a line
discipline forwards an empty write request.