Re: [PATCH] mos7840: fix chars_in_buffer() return value

From: Stas Sergeev
Date: Thu Sep 29 2016 - 17:00:56 EST

29.09.2016 13:09, Johan Hovold ÐÐÑÐÑ:
On Sat, Sep 24, 2016 at 06:00:57PM +0300, Stas Sergeev wrote:
The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on
a correct behaviour of that.
mos7840 implements it wrongly: if you write just one char, TIOCOUTQ
will return 32.
This patch should fix it by accounting the number of chars actually
This patch, unfortunately, misses the Tested-by tag.
The reporter didn't test it, and I don't have the hardware in question.
Why do you think the driver returns 32b in chars_in_buffer after writing
a single character?
Hi Johan, this actually came from this ancient bug report:
I was trying to add you back then and now, but your e-mail
doesn't seem to be registered in a bug tracker.
The code in question was different when I submitted the
original patch:
Maybe the bug was since fixed.
In that case sorry for the noise.