Re: [PATCH 2/2] Revert "staging: wilc1000: Replace kthread with workqueue for host interface"

From: Greg KH
Date: Fri Sep 30 2016 - 09:22:36 EST

On Fri, Sep 30, 2016 at 03:43:18PM +0530, Aditya Shankar wrote:
> This reverts commit 2518ac59eb27 ("staging: wilc1000: Replace kthread
> with workqueue for host interface")
> This commit breaks wilc1000 driver init. A crash was seen
> everytime the wlan interface was brought up and wilc device
> open was attempted. This change is being reverted until we
> figure out the problem in this change. The driver is
> usable now with this change reverted.
> Signed-off-by: Aditya Shankar <Aditya.Shankar@xxxxxxxxxxxxx>
> Conflicts:
> drivers/staging/wilc1000/host_interface.c

What is this line doing here?

And shouldn't we add a cc: stable tag as well? Or at the least, put a
"fixes:" tag to let people know exactly what commit it is fixing (the
id that it is reverting.)


greg k-h