Re: [PATCH v3 04/18] x86/intel_rdt: Feature discovery
From: Borislav Petkov
Date: Sat Oct 08 2016 - 15:53:10 EST
On Sat, Oct 08, 2016 at 01:54:54PM -0700, Fenghua Yu wrote:
> > I think these #defines are specific to Intel. I would prefer if we
> > have _INTEL_ somewhere in them.
We don't generally add vendor names to those defines. Even more so if
the 0x0... leaf range is Intel-specific anyway.
> Is adding "Intel" in comment good?
I don't see any need if the leaf has already this heading:
/* Intel-defined CPU features, CPUID level 0x00000007:0 (ebx), word 9 */
SUSE Linux GmbH, GF: Felix ImendÃrffer, Jane Smithard, Graham Norton, HRB 21284 (AG NÃrnberg)