Re: [PATCH v3 04/18] x86/intel_rdt: Feature discovery
From: Nilay Vaish
Date: Tue Oct 11 2016 - 12:59:55 EST
On 8 October 2016 at 14:52, Borislav Petkov <bp@xxxxxxx> wrote:
> On Sat, Oct 08, 2016 at 01:54:54PM -0700, Fenghua Yu wrote:
>> > I think these #defines are specific to Intel. I would prefer if we
>> > have _INTEL_ somewhere in them.
> We don't generally add vendor names to those defines. Even more so if
> the 0x0... leaf range is Intel-specific anyway.
>> Is adding "Intel" in comment good?
> I don't see any need if the leaf has already this heading:
> /* Intel-defined CPU features, CPUID level 0x00000007:0 (ebx), word 9 */
I think we should go with Fenghua' suggestion on this. Reading the
code around the edits from this patch, it seems word 7 is not owned by
anyone. Both AMD and Intel seem to be using it.