Re: [PATCH] watchdog: at91sam9: keep watchdog running in idle mode

From: Guenter Roeck
Date: Sun Oct 16 2016 - 11:51:09 EST


On 10/16/2016 08:33 AM, Sylvain Rochet wrote:
Hi,

On Wed, Oct 07, 2015 at 01:01:12PM +0200, Alexandre Belloni wrote:
On 06/10/2015 at 22:28:45 +0200, Sylvain Rochet wrote :
Since turning on idle-halt in commit 5161b31dc39a (watchdog:
at91sam9_wdt: better watchdog support"), SoCs compatible with
at91sam9260-wdt not using a device tree no longer reboot if the watchdog
times out while the CPU is in idle state. Removing the
AT91_WDT_WDIDLEHLT flag that was set by default fixes this.

Signed-off-by: Sylvain Rochet <sylvain.rochet@xxxxxxxxxxxx>
Fixes: 5161b31dc39a ("watchdog: at91sam9_wdt: better watchdog support")
Cc: <stable@xxxxxxxxxxxxxxx> # 3.14+

Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>

However, we don't really care about that for kernels after 3.18 as no
users are using pdata anymore.
I think you could send a follow-up patch removing pdata support
completely.

Looks like this one falls through the cracks, it didn't reach mainline
and therefore wasn't applied to stable branches.

Possibly that happened because you did not copy the watchdog mailing list.

Guenter

I just checked, it still apply properly on today's linux-next branch.

Cheers,
Sylvain