[PATCH 3.12 37/84] xfs: fixed signedness of error code in xfs_inode_buf_verify

From: Jiri Slaby
Date: Mon Oct 17 2016 - 04:13:06 EST

From: Jeff Mahoney <jeffm@xxxxxxxx>

3.12-stable review patch. If anyone has any objections, please let me know.


Prior to v3.17, XFS used positive error codes internally. Commit
af8d971602b9583e5e8400e637e2a48c7480bc64 (xfs: inode recovery
readahead can race with inode buffer creation), upstream commit
b79f4a1c68bb99152d0785ee4ea3ab4396cdacc6 backported from later
releases need the error code signs reversed. Negative error codes
will cause assertion failures (BUG_ON on kernels with assertions

Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx>
Cc: Dave Chinner <dchinner@xxxxxxxxxx>
Cc: Brian Foster <bfoster@xxxxxxxxxx>
Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
fs/xfs/xfs_inode_buf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_inode_buf.c b/fs/xfs/xfs_inode_buf.c
index 4b1447b3a9e4..03d237a0f58b 100644
--- a/fs/xfs/xfs_inode_buf.c
+++ b/fs/xfs/xfs_inode_buf.c
@@ -99,7 +99,7 @@ xfs_inode_buf_verify(
if (readahead) {
bp->b_flags &= ~XBF_DONE;
- xfs_buf_ioerror(bp, -EIO);
+ xfs_buf_ioerror(bp, EIO);