Re: [PATCH 07/10] perf, tools: Collapse identically named events in perf stat

From: Jiri Olsa
Date: Mon Oct 17 2016 - 07:23:47 EST


On Thu, Oct 13, 2016 at 02:15:29PM -0700, Andi Kleen wrote:

SNIP

> + OPT_BOOLEAN(0, "no-merge", &no_merge, "Do not merge identical named events"),
> OPT_STRING('x', "field-separator", &csv_sep, "separator",
> "print counts with custom separator"),
> OPT_CALLBACK('G', "cgroup", &evsel_list, "name",
> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> index b1503b0ecdff..4e3158fe79c2 100644
> --- a/tools/perf/util/evsel.h
> +++ b/tools/perf/util/evsel.h
> @@ -128,6 +128,7 @@ struct perf_evsel {
> bool cmdline_group_boundary;
> struct list_head config_terms;
> int bpf_fd;
> + bool alias;

I think we should call this some other name,
we already use alias for something else..
also alias->alias looks bad ;-)

how about 'merged_stats'

jirka