Re: [PATCH v4 7/8] drivers:input:ads7846(+tsc2046): fix spi module table
From: H. Nikolaus Schaller
Date: Mon Oct 17 2016 - 12:53:21 EST
> Am 17.10.2016 um 17:54 schrieb Andrew F. Davis <afd@xxxxxx>:
>
> On 10/17/2016 08:57 AM, H. Nikolaus Schaller wrote:
>> Fix module table so that the driver is loaded if compiled
>> as module and requested by DT.
>>
>> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
>> ---
>> drivers/input/touchscreen/ads7846.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
>> index 400e421..9a5d84d 100644
>> --- a/drivers/input/touchscreen/ads7846.c
>> +++ b/drivers/input/touchscreen/ads7846.c
>> @@ -1532,6 +1532,17 @@ static int ads7846_remove(struct spi_device *spi)
>> return 0;
>> }
>>
>> +static const struct spi_device_id ads7846_idtable[] = {
>> + { "tsc2046", 0 },
>> + { "ads7843", 0 },
>> + { "ads7845", 0 },
>> + { "ads7846", 0 },
>> + { "ads7873", 0 },
>> + { }
>> +};
>> +
>
> no space needed
>
>> +MODULE_DEVICE_TABLE(spi, ads7846_idtable);
>> +
>> static struct spi_driver ads7846_driver = {
>> .driver = {
>> .name = "ads7846",
>>
>
> the MODULE_ALIAS below can now also be removed with this patch.
Ok! Noted for V5.
BR and thanks,
Nikolaus