[PATCH] e1000e: x86: e1000 driver trying to free already-free irq.

From: David Singleton
Date: Mon Oct 17 2016 - 13:07:03 EST

From: khalidm <khalidm@xxxxxxxxx>

During systemd reboot sequence network driver interface is shutdown
by e1000_close. The PCI driver interface is shut by e1000_shutdown.
The e1000_shutdown checks for netif_running status, if still up it
brings down driver. But it disables msi outside of this if statement,
regardless of netif status. All this is OK when e1000_close happens
after shutdown. However, by default, everything in systemd is done
in parallel. This creates a conditions where e1000_shutdown is called
after e1000_close, therefore hitting BUG_ON assert in free_msi_irqs.

Cc-Id: xe-kernel@xxxxxxxxxxxxxxxxxx
Signed-off-by: khalidm <khalidm@xxxxxxxxx>
Signed-off-by: David Singleton <davsingl@xxxxxxxxx>
drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 7017281..79f02a6 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -6283,8 +6283,8 @@ static int e1000e_pm_freeze(struct device *dev)
/* Quiesce the device without resetting the hardware */
e1000e_down(adapter, false);
+ e1000e_reset_interrupt_capability(adapter);
- e1000e_reset_interrupt_capability(adapter);

/* Allow time for pending master requests to run */