Re: [PATCH 02/10] mfd: dt-bindings: Add bindings for the Juniper I2CS MFD

[Pantelis Antoniou]

Hi Rob,

> On Oct 10, 2016, at 23:23 , Rob Herring <robh@xxxxxxxxxx> wrote:
> 
> On Fri, Oct 07, 2016 at 06:21:01PM +0300, Pantelis Antoniou wrote:
>> From: Georgi Vlaev <gvlaev@xxxxxxxxxxx>
>> 
>> Add device tree bindings for the Juniper I2CS MFD driver.
>> 
>> Signed-off-by: Georgi Vlaev <gvlaev@xxxxxxxxxxx>
>> [Ported from Juniper kernel]
>> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@xxxxxxxxxxxx>
>> ---
>> Documentation/devicetree/bindings/mfd/jnx-i2cs.txt | 68 ++++++++++++++++++++++
>> 1 file changed, 68 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/jnx-i2cs.txt
>> 
>> diff --git a/Documentation/devicetree/bindings/mfd/jnx-i2cs.txt b/Documentation/devicetree/bindings/mfd/jnx-i2cs.txt
>> new file mode 100644
>> index 0000000..0ec103b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/jnx-i2cs.txt
>> @@ -0,0 +1,68 @@
>> +Device-Tree bindings for Juniper Networks I2CS FPGA MFD
>> +
>> +Required properties:
>> +- compatible - Must be one of:
>> +	"jnx,i2cs-rcb"	(Routing Engine or Control Board FRUs)
>> +	"jnx,i2cs-fpc"	(Flexible Port Concentrator FRUs)
>> +	"jnx,i2cs-sib"	(Switching Interface Board FRUs)
>> +	"jnx,i2cs-fan"	(Fan Tray FRUs)
>> +
>> +Optional properties:
>> +
>> +Depending on the FRU, the I2CS MFD has varied group of sub-devices:
>> +
>> +Device                   Description
>> +------                   -----------
>> +jnx,i2cs-gpio		: Virtual gpio mapping driver
>> +jnx,i2cs-fan-hwmon	: hwmon driver for fan trays
>> +jnx,i2c-mux-i2cs	: I2C Mux driver for FPC FRUs
>> +jnx,leds-i2cs		: Led driver
>> +
>> +All these optional nodes are described in their respective binding
>> +documents.
>> +
>> +Example node:
>> +
>> +i2cs@54 {
>> +	compatible = "jnx,i2cs-fpc";
>> +	reg = <0x54>;
>> +	#address-cells = <0>;
>> +	#size-cells = <0>;
>> +
>> +	fpc2_mux {
> 
> Generic node names please.
> 

OK.

> mux { 
> 
>> +		compatible = "jnx,i2c-mux-i2cs";
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		fpc2i2c0: i2c@0 {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			reg = <0>;
>> +		};
>> +	};
>> +
>> +	fpc2_gpiomap: gpio-jnx-i2cs {
> 
> gpio@54 {
> 
OK

>> +		compatible = "jnx,gpio-i2cs";
>> +		reg = <0x54>;
>> +		#gpio-cells = <2>;
>> +		gpio-controller;
>> +		interrupt-controller;
>> +
>> +		/*
>> +		 * Map bits [0-3] of reg 0x21 as gpio inputs, bits [4-7]
>> +		 * as gpio outputs
>> +		 */
>> +		i2c-gpio-map = <0x21 0x0f>;
>> +	};
>> +
>> +	leds-jnx-i2cs {
> 
> leds {
> 

OK.

>> +		compatible = "jnx,leds-i2cs";
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		sib8-active {
>> +			reg = <0>;
>> +			linux,default-trigger = "sib8-active";
>> +		};
>> +	};
>> +};
>> -- 
>> 1.9.1