Re: [PATCH 1/3] tools lib traceevent: Add -O2 option to traceevent

[Namhyung Kim]

Hi Honggyu,

You need to CC relevant maintainers when you send patches to LKML.
For the libtraceevent, they are Arnaldo and Steven.  You can use
scripts/get_maintainer.pl for this job later.  In addition running
scripts/checkpatch.pl before sending patches is a good habit.

Arnaldo and Steve,

This is from uftrace building libtraceevent with the optimization flag
and we want to fix the upstream as well.

Thanks,
Namhyung


On Mon, Oct 17, 2016 at 11:17:10PM +0900, Honggyu Kim wrote:
> Since current traceevent somehow does not have an optimization flag,
> this patch just adds -O2 to optimize its code.
> 
> Signed-off-by: Honggyu Kim <hong.gyu.kim@xxxxxxx>
> ---
>  tools/lib/traceevent/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> index 7851df1..56d223b 100644
> --- a/tools/lib/traceevent/Makefile
> +++ b/tools/lib/traceevent/Makefile
> @@ -124,7 +124,7 @@ else
>  endif
>  
>  # Append required CFLAGS
> -override CFLAGS += -fPIC
> +override CFLAGS += -O2 -fPIC
>  override CFLAGS += $(CONFIG_FLAGS) $(INCLUDES) $(PLUGIN_DIR_SQ)
>  override CFLAGS += $(udis86-flags) -D_GNU_SOURCE
>  
> -- 
> 2.10.0.rc2.dirty
>