Re: [PATCH -v4 1/8] locking/drm: Kill mutex trickery

From: Chris Wilson
Date: Tue Oct 18 2016 - 08:58:30 EST


On Tue, Oct 18, 2016 at 02:48:41PM +0200, Peter Zijlstra wrote:
> On Fri, Oct 07, 2016 at 04:52:44PM +0200, Peter Zijlstra wrote:
> > Poking at lock internals is not cool. Since I'm going to change the
> > implementation this will break, take it out.
> >
> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Rob Clark <robdclark@xxxxxxxxx>
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/i915/i915_gem_shrinker.c | 26 +++-----------------------
> > drivers/gpu/drm/msm/msm_gem_shrinker.c | 23 +++--------------------
> > 2 files changed, 6 insertions(+), 43 deletions(-)
>
> OK, so it appears that i915 changed their locking around and got rid of
> this thing entirely. Much appreciated Chris!!

It's not dead yet! Sorry.

It's close though, in the next cycle we may be at a point where we don't
rely on recursion locking in the shrinker.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre