Re: [REVIEW][PATCH] exec: Don't exec files the userns root can not read.

From: Andy Lutomirski
Date: Wed Oct 19 2016 - 11:30:43 EST


On Tue, Oct 18, 2016 at 2:15 PM, Eric W. Biederman
<ebiederm@xxxxxxxxxxxx> wrote:
>
> When the user namespace support was merged the need to prevent
> ptracing an executable that is not readable was overlooked.

Before getting too excited about this fix, isn't there a much bigger
hole that's been there forever? Simply ptrace yourself, exec the
program, and then dump the program out. A program that really wants
to be unreadable should have a stub: the stub is setuid and readable,
but all the stub does is to exec the real program, and the real
program should have mode 0500 or similar.

ISTM the "right" check would be to enforce that the program's new
creds can read the program, but that will break backwards
compatibility.

--Andy