Re: [PATCH -next] greybus: es2: fix error return code in ap_probe()

[Viresh Kumar]

On Wed, Oct 19, 2016 at 6:47 PM, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote:
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> Fix to return a negative error code from the es2_arpc_in_enable() error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: 9d9d3777a9db ("greybus: es2: Add a new bulk in endpoint for
> APBridgeA RPC")
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
>  drivers/staging/greybus/es2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
> index 8eabc71..a97fccf 100644
> --- a/drivers/staging/greybus/es2.c
> +++ b/drivers/staging/greybus/es2.c
> @@ -1547,7 +1547,8 @@ static int ap_probe(struct usb_interface *interface,
>         INIT_LIST_HEAD(&es2->arpcs);
>         spin_lock_init(&es2->arpc_lock);
>
> -       if (es2_arpc_in_enable(es2))
> +       retval = es2_arpc_in_enable(es2);
> +       if (retval)
>                 goto error;
>
>         retval = gb_hd_add(hd);

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>