Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

[Andy Shevchenko]

On Wed, 2016-10-19 at 19:53 +0300, Andy Shevchenko wrote:
> On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote:
> > 
> > netdev_alloc_skb function
> > already set dev member of pkt_copy.
> 
> It might be one line.
> 
> Some special references:
> functions: function()
> structs: struct my_struct
> 
> P.S. Entire series lacks of cover letter.

And couple more things:
Â- Use min percentage when run git format-patch to avoid inclusion non-
maintainers / non-active developers
Â- Adjust your commit messages to be a bit more verbose and put
explanation "why you create the patch" before "what is done in the
patch".

> 
> > 
> > 
> > Signed-off-by: Ivan Safonov <insafonov@xxxxxxxxx>
> > ---
> > Âdrivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 -
> > Â1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
> > b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
> > index 34198fe..f19b203 100644
> > --- a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
> > +++ b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
> > @@ -123,7 +123,6 @@ static int recvbuf2recvframe(struct adapter
> > *adapt, struct sk_buff *pskb)
> > Â
> > Â		pkt_copy = netdev_alloc_skb(adapt->pnetdev,
> > alloc_sz);
> > Â		if (pkt_copy) {
> > -			pkt_copy->dev = adapt->pnetdev;
> > Â			precvframe->pkt = pkt_copy;
> > Â			precvframe->rx_head = pkt_copy->data;
> > Â			precvframe->rx_end = pkt_copy->data +
> > alloc_sz;
> 

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy