Re: [PATCH] toshiba-wmi: Fix loading the driver on non Toshiba laptops
From: Darren Hart
Date: Wed Oct 19 2016 - 16:26:38 EST
On Wed, Oct 12, 2016 at 10:26:43AM -0600, Azael Avalos wrote:
> 2016-08-28 11:00 GMT-06:00 Darren Hart <dvhart@xxxxxxxxxxxxx>:
> > On Thu, Aug 25, 2016 at 12:50:55PM -0600, Azael Avalos wrote:
> >> Bug 150611 uncovered that the WMI ID used by the toshiba-wmi driver
> >> is not Toshiba specific, and as such, the driver was being loaded
> >> on non Toshiba laptops too.
> >> This patch adds a DMI matching list checking for TOSHIBA as the
> >> vendor, refusing to load if it is not.
> >> Also the WMI GUID was renamed, dropping the TOSHIBA_ prefix, to
> >> better reflect that such GUID is not a Toshiba specific one.
> >> Cc: <stable@xxxxxxxxxxxxxxx> # 4.4+
> >> Signed-off-by: Azael Avalos <coproscefalo@xxxxxxxxx>
> >> ---
> >> Hi Darren,
> >> I was waiting on input from the bug above, but haven't received an
> >> answer (as of yet), so I decided to send this to the mailing list
> >> for feedback as to whether this is the correct approach for this
> >> issue.
> > Thanks. Let's see if Carlos (wmi.c author) has an opinion...
> > Carlos?
> Any input on this?
Looks like a sane workaround to me. Queued to fixes.
Want to going to stable?
Intel Open Source Technology Center