RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

[Sell, Timothy C]

> -----Original Message-----
> From: Kershner, David A
> Sent: Wednesday, October 19, 2016 8:04 PM
> To: Cathal Mullaney <chuckleberryfinn@xxxxxxxxx>

> Subject: RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor
> locking code to be statically deterministic.
> 
> > -----Original Message-----
> > From: Cathal Mullaney [mailto:chuckleberryfinn@xxxxxxxxx]
> > Subject: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking
> > code to be statically deterministic.
> >
> > This patch makes locking in visorchannel_signalempty statically
> > deterministic.
> > As a result this patch fixes the sparse warning:
> > Context imbalance in 'visorchannel_signalempty' - different lock
> > contexts for basic block.
> >
> > The logic of the locking code doesn't change but the layout of the
> > original code is "frowned upon"
> > according to mails on sparse context checking.
> > Refactoring removes the warning and makes the code more readable.
> >
> > Signed-off-by: Cathal Mullaney <chuckleberryfinn@xxxxxxxxx>
> 
> Tested-by: David Kershner <david.kershner@xxxxxxxxxx>
> 
> > ---
> > V2: Removed unnecessary variable initialization, as suggested by Tim Sell
> > <Timothy.Sell@xxxxxxxxxx>.
> >
> >  drivers/staging/unisys/visorbus/visorchannel.c | 30 ++++++++++++++++--
> --
> > ------

Thanks for the quick turnaround, folks.
v2 looks great to me.

- Tim Sell