Re: [PATCH v2 3/4] ACPI / gpio: Add hogging support

[Mika Westerberg]

On Thu, Oct 20, 2016 at 02:09:30PM +0200, Linus Walleij wrote:
> On Thu, Sep 29, 2016 at 3:39 PM, Mika Westerberg
> <mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> 
> > GPIO hogging means that the GPIO controller can "hog" and configure certain
> > GPIOs without need for a driver or userspace to do that. This is useful in
> > open-connected boards where BIOS cannot possibly know beforehand which
> > devices will be connected to the board.
> >
> > This adds GPIO hogging mechanism to ACPI analogous to Device Tree.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> 
> Overall nice to have the hogs in ACPI too!
> 
> Again here my comment is to break out device_property() and fwnode_*
> accessing code to a file shared between ACPI and OF.
> 
> If it makes sense.
> 
> Because the idea was not to invent those abstractions in order to
> just use them with ACPI I hope.
> 
> The problem is that some of the code seems to be ACPI-specific,
> so if it doesn't work out, I'm also OK to keep it like this.

Yeah, this one differs between ACPI and DT and I'm not sure if it can be
easily generalized using device_property APIs.