Re: [PATCH] net: smc91x: fix neponset breakage by pxa u16 writes

From: David Miller
Date: Thu Oct 20 2016 - 11:21:22 EST


From: Robert Jarzmik <robert.jarzmik@xxxxxxx>
Date: Wed, 19 Oct 2016 23:23:50 +0200

> The patch isolating the u16 writes for pxa assumed all machine_is_*()
> calls were removed, and therefore removed the mach-types.h include which
> provided them.
>
> Unfortunately 2 machine_is_*() remained in smc91x.c file including
> smc91x.h from which the include was removed, triggering the error:
> drivers/net/ethernet/smsc/smc91x.c: In function ʽsmc_drv_probeʼ:
> drivers/net/ethernet/smsc/smc91x.c:2380:2: error: implicit declaration
> of function ʽmachine_is_assabetʼ
> [-Werror=implicit-function-declaration]
> if (machine_is_assabet() && machine_has_neponset())
>
> This adds back the wrongly removed include.
>
> Fixes: d09d747ae4c2 ("net: smc91x: isolate u16 writes alignment workaround")
> Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>

Applied.