Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

From: Nilay Vaish
Date: Thu Oct 20 2016 - 12:41:58 EST


On 19 October 2016 at 17:01, Jin Yao <yao.jin@xxxxxxxxxxxxxxx> wrote:
> diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
> index 40ecf25..4f6bf6c 100644
> --- a/tools/perf/util/callchain.h
> +++ b/tools/perf/util/callchain.h
> @@ -115,6 +115,10 @@ struct callchain_list {
> bool unfolded;
> bool has_children;
> };
> + u64 branch_count;
> + u64 predicted_count;
> + u64 abort_count;

Can you explain what abort count is? It seems you are referring to
miss-speculated branches. If that is the case, I would prefer that we
replace abort by miss_speculated or miss_predicted.

--
Nilay