Re: [PATCH 3/4] ptp_clock: allow for it to be optional
From: Thomas Gleixner
Date: Thu Oct 20 2016 - 14:01:24 EST
On Thu, 20 Oct 2016, Nicolas Pitre wrote:
> On Thu, 20 Oct 2016, Thomas Gleixner wrote:
> > On Wed, 19 Oct 2016, Nicolas Pitre wrote:
> > > The pch_gbe driver is a bit special as it relies on extra code in
> > > drivers/ptp/ptp_pch.c. Therefore we let the make process descend into
> > > drivers/ptp/ even if PTP_1588_CLOCK is unselected.
> > The above paragraph looks like a leftover of the previous patch set.
> Not really. Without the change to drivers/Makefile, drivers/ptp/ is not
> visited when CONFIG_PTP_1588_CLOCK=n. If you then have CONFIG_PCH_GBE=y
> you end up with:
> drivers/built-in.o: In function `pch_gbe_ioctl':
> pch_gbe_main.c:(.text+0x28c914): undefined reference to `pch_ch_control_write'
> Hence the above paragraph.
Indeed. I misread that.