Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

From: Jin, Yao
Date: Thu Oct 20 2016 - 20:23:48 EST

Hi Andi, Hi Nilay,

Thanks so much for your comments!

I will upgrade the patch to just display the count for abort.


Jin Yao

On 10/21/2016 2:20 AM, Andi Kleen wrote:
OK, I am more confused now. Are you predicting some quantity related
to transactions? Why would you divide abort count by branch count?
Further, I just looked at patch 6/6. It has the following text:

+ Also show with some branch flags that can be:
+ - Predicted: display the average percentage of predicated branches.
+ (predicated number / total number)
+ - Abort: display the average percentage of abort branches.
+ (abort number /total number)
+ - Cycles: cycles in basic block.

I think there is inconsistency between what you are suggesting and
what the patch has.
An abort is an unique branch. But yes there is no total number,
so the formula will always be 100%. So yes would probably be
better to just display a count for abort.