Re: [PATCH 01/26] fscrypto: Add buffer operations
From: Christoph Hellwig
Date: Fri Oct 21 2016 - 09:24:07 EST
On Fri, Oct 21, 2016 at 03:17:03PM +0200, Richard Weinberger wrote:
> UBIFS works on kmalloc()'ed buffers where it constructs the NAND/NOR pages
> which will be written to the MTD. JFFS2 does the same.
Yes, you can trivially do a virt_to_page on a kmalloc buffer.
> Another reason why I did the buffer functions is because fscrypt_encrypt_page()
> always allocates a bounce page as temporary memory. For ext4 this is needed,
> for UBIFS not.
> UBIFS has already a construction buffer, especially since it also does compression.
We should defintively find a way to avoid that, but it's a separate
issue from adding another API just to pass buffers.