Re: [PATCH 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX preemption timer support

From: Wanpeng Li
Date: Fri Oct 21 2016 - 09:38:51 EST

2016-10-21 2:10 GMT+08:00 Radim KrÄmÃÅ <rkrcmar@xxxxxxxxxx>:
> 2016-10-20 06:57+0800, Wanpeng Li:
>> 2016-10-20 3:28 GMT+08:00 Radim KrÄmÃÅ <rkrcmar@xxxxxxxxxx>:
>>> I think it would be better to add a function to advance the periodic
>>> timer and use it in kvm_lapic_expired_hv_timer() and in apic_timer_fn().
>>> The function can be simpler than set_target_expiration(), because it
>>> just adds the period to an existing timer. Periodic timer will also be
>>> better then, because the period will not depend on KVM's latency when
>>> rearming.
>> Good point, what's the function name do you like? How about
>> advance_target_expiration()?
> Sounds good, I'd just slap periodic somewhere,
> advance_periodic_target_expiration()?

Cool, thanks for your review. :)

Wanpeng Li