Re: + proc-fix-null-dereference-when-reading-proc-pid-auxv.patch added to -mm tree

[Michal Hocko]

On Fri 21-10-16 16:44:03, Alexey Dobriyan wrote:
> On Fri, Oct 21, 2016 at 6:13 AM,  <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > Reading auxv of any kernel thread results in NULL pointer dereferencing in
> > auxv_read() where mm can be NULL.  Fix that by checking for NULL mm and
> > bailing out early.  This is also the original behavior changed by recent
> > commit c5317167854e ("proc: switch auxv to use of __mem_open()").
> 
> > --- a/fs/proc/base.c~proc-fix-null-dereference-when-reading-proc-pid-auxv
> > +++ a/fs/proc/base.c
> > @@ -1014,6 +1014,9 @@ static ssize_t auxv_read(struct file *fi
> >  {
> >         struct mm_struct *mm = file->private_data;
> >         unsigned int nwords = 0;
> > +
> > +       if (!mm)
> > +               return 0;
> 
> Rhetorical question: who wrote such clever __mem_open() ?

This is nothing really new. __mem_open resp. proc_mem_open returned NULL
mm for ages. I was suggesting to return ESRCH for NULL mm [1].

[1] http://lkml.kernel.org/r/20161019171748.GO24393@xxxxxxxxxxxxxx

-- 
Michal Hocko
SUSE Labs