Re: [PATCH] block: Change extern inline to static inline

From: Mika Westerberg
Date: Fri Oct 21 2016 - 10:29:09 EST

On Fri, Oct 21, 2016 at 04:19:26PM +0200, Tobias Klauser wrote:
> With compilers which follow the C99 standard (like modern versions of
> gcc and clang), "extern inline" does the opposite thing from older
> versions of gcc (emits code for an externally linkable version of the
> inline function).
> "static inline" does the intended behavior in all cases instead.
> Description taken from commit 6d91857d4826 ("staging, rtl8192e,
> LLVMLinux: Change extern inline to static inline").
> This also fixes the following GCC warning when building with !PM:
> ./include/linux/blkdev.h:1143:20: warning: no previous prototype for 'blk_set_runtime_active' [-Wmissing-prototypes]
> Fixes: d07ab6d11477 ("block: Add blk_set_runtime_active()")
> Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Hehe, indeed that "extern" was probably copy pasted from the non-inline

Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>