Re: [PATCH] clk: fix link error for rcar-gen2

From: Sergei Shtylyov
Date: Fri Oct 21 2016 - 12:43:00 EST


Hello.

On 10/21/2016 06:47 PM, Arnd Bergmann wrote:

The addition of one more rcar-gen2 based SoC caused a build error (again)
in my randconfig builds:

arch/arm/mach-shmobile/setup-rcar-gen2.o: In function `rcar_gen2_timer_init':
setup-rcar-gen2.c:(.init.text+0x200): undefined reference to `rcar_gen2_clocks_init'

OK, seeing how you got this -- I should have tested the kernel build with only R8A7743 enabled... sorry about that. :-<
I probably shouldn't have used rcar_gen2_timer_init() in the 1st place...

I think this has happened twice in the past. Instead of adding each SoC
one at a time, this changes the existing list to always build the
rcar-gen2 related clk files whenever the generic symbol is selected.

The problem is we're not going to use this driver on RZ/G SoCs... The newer rcar2-cpg-mssr.c will be used instead -- I submitted the patches for that before ELC-E...

Fixes: 1254f607fc3d ("ARM: shmobile: r8a7743: basic SoC support")
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
[...]

MBR, Sergei