Re: [PATCH 25/26] ubifs: Implement UBIFS_FLG_ENCRYPTION
From: Eric Biggers
Date: Fri Oct 21 2016 - 14:30:22 EST
On Fri, Oct 21, 2016 at 02:48:40PM +0200, Richard Weinberger wrote:
> @@ -190,6 +191,10 @@ long ubifs_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> return -EFAULT;
> + err = ubifs_enable_encryption(c);
> + if (err)
> + return err;
> err = fscrypt_process_policy(file, &policy);
Is ubifs_enable_encryption() being done with proper locking and authorization?
As-is, anyone can call this at any time if they can open some file on UBIFS.
FYI, the approach being taken for ext4 is that the encryption feature flag has
to be explicitly turned on before FS_IOC_SET_ENCRYPTION_POLICY will work.