Re: [PATCH] uapi: linux: acct: Remove redundant type comp2_t from kernel
From: Chen Gang
Date: Fri Oct 21 2016 - 18:51:10 EST
On 10/21/16 11:41, Andrew Morton wrote:
> On Wed, 5 Oct 2016 21:40:10 +0800 chengang@xxxxxxxxxxxxxxxx wrote:
>> In api itself, kernel does not use it -- it is divided into ac_etime_hi
>> and ac_etime_lo. So kernel side only need generate the correct
>> ac_etime_hi and ac_etime_lo, but need not know about comp2_t.
>> At present, kernel use normal u64 type for it, when kernel provdes it to
>> outside, kernel can translate it into ac_etime_hi and ac_etime_lo,
>> directly, but need not notice about comp2_t, in fact.
> hm. Why is this an improvement?
For me, it will let code a little more understanding, a little simpler,
and let the code a little more extendable (when kernel members really
needs comp2_t in future, they need not have to treat it as __u32).
Only when comp2_t is really used in api header in future, kernel has to
know about it, but kernel still can keep original code no touch. So for
me, our changing is harmless.
Chen Gang (éå)
Managing Natural Environments is the Duty of Human Beings.