Re: [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection

From: H. Nikolaus Schaller
Date: Tue Oct 25 2016 - 13:19:16 EST



> Am 25.10.2016 um 18:51 schrieb Peter Ujfalusi <peter.ujfalusi@xxxxxx>:
>
> On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote:
>> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
>> ---
>> arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
>> index b04adee..91456b4 100644
>> --- a/arch/arm/boot/dts/omap5-board-common.dtsi
>> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi
>> @@ -124,6 +124,7 @@
>> compatible = "ti,abe-twl6040";
>> ti,model = "omap5-uevm";
>>
>> + ti,jack_detection;
>
> ti,jack-detection

Hm. Looks as if we have found another bug:
which one is correct?

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt#n15

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/soc/omap/omap-abe-twl6040.c#n289

Should I add another patch?

>
>> ti,mclk-freq = <19200000>;
>>
>> ti,mcpdm = <&mcpdm>;
>>
>
>
> --
> PÃter