Re: [RFC/PATCH 2/2] perf sched: Make common options cascading

From: Arnaldo Carvalho de Melo
Date: Tue Oct 25 2016 - 13:21:41 EST


Em Mon, Oct 24, 2016 at 07:03:32PM +0200, Jiri Olsa escreveu:
> On Mon, Oct 24, 2016 at 12:00:03PM +0900, Namhyung Kim wrote:
> > The -i and -v options can be used in subcommands so enable cascading the
> > sched_options. This fixes the following inconvenience in 'perf sched':
> >
> > $ perf sched -i perf.data.sched map
> > ... (it works well) ...
> >
> > $ perf sched map -i perf.data.sched
> > Error: unknown switch `i'
> >
> > Usage: perf sched map [<options>]
> >
> > --color-cpus <cpus>
> > highlight given CPUs in map
> > --color-pids <pids>
> > highlight given pids in map
> > --compact map output in compact mode
> > --cpus <cpus> display given CPUs in map
> >
> > With this patch, the second command line works with the perf.data.sched
> > data file.
> >
> > Cc: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
>
> good idea, I'll use it in c2c ;-)
>
> for both:
>
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

Applied, I guess 'perf kvm' would be another user, to make it sane wrt
file_name, -i and -o being available for 'perf kvm record', etc.

- Arnaldo