Re: [PATCH v2] dmaengine: DW DMAC: split pdata to hardware properties and platform quirks

[Andy Shevchenko]

On Thu, 2016-10-27 at 18:34 +0300, Eugeniy Paltsev wrote:
> This patch is to address a proposal by Andy in this thread:
> http://www.spinics.net/lists/dmaengine/msg11506.html
> Split platform data to actual hardware properties, and platform
> quirks.
> Now we able to use quirks and hardware properties separately from
> different sources (pdata, device tree or autoconfig registers)
> 

Thanks for an update, my comments below.

> ---
> Changes for v2:
> ÂÂÂ- use separate bool values for quirks in "dw_dma_platform_data"
> instead of
> ÂÂÂÂÂcommon bit field.

> ÂÂÂ- convert device tree properties reading to unified device property
> API.

This should be a separate patch.

> 
> I was wrong about DW_DMA_IS_SOFT_LLP flag - it is used to check about
> ongoing soft llp transfer. So DW_DMA_IS_SOFT_LLP flag and "dwc-
> >nollp"Â
> variable have different functions and I couldn't just get rid of "dwc-
> >nollp"
> and use DW_DMA_IS_SOFT_LLP flag instead. So I left "dwc->nollp"
> untouched.

So, then perhaps we may convert it to another flag let's say
DW_DMA_IS_LLP_SUPPORTED.

But this is other story independent of the subject.

> --- a/drivers/dma/dw/core.c
> +++ b/drivers/dma/dw/core.c
> @@ -1452,9 +1452,24 @@ int dw_dma_probe(struct dw_dma_chip *chip)
> Â	dw->regs = chip->regs;
> Â	chip->dw = dw;
> Â
> +	/* Reassign the platform data pointer */
> +	pdata = dw->pdata;
> +
> Â	pm_runtime_get_sync(chip->dev);
> Â
> -	if (!chip->pdata) {
> +	if ((!chip->pdata) || (chip->pdata && chip->pdata-
> >only_quirks_used)) {

It's simple as
if (!chip->pdata || chip->pdata->only_quirks_used)

> +		if (!chip->pdata) {
> +			/*
> +			Â* Fill quirks with the default values in
> case of
> +			Â* pdata absence.
> +			Â*/
> +			pdata->is_private = true;
> +			pdata->is_memcpy = true;
> +		} else {
> +			pdata->is_private = chip->pdata->is_private;
> +			pdata->is_memcpy = chip->pdata->is_memcpy;
> +		}

Would we leave the first part in the place it is now and add new piece
after?

> +
> Â		dw_params = dma_readl(dw, DW_PARAMS);
> Â		dev_dbg(chip->dev, "DW_PARAMS: 0x%08x\n", dw_params);
> Â
> @@ -1464,9 +1479,6 @@ int dw_dma_probe(struct dw_dma_chip *chip)
> Â			goto err_pdata;
> Â		}
> Â
> -		/* Reassign the platform data pointer */
> -		pdata = dw->pdata;
> -
> Â		/* Get hardware configuration parameters */
> Â		pdata->nr_channels = (dw_params >> DW_PARAMS_NR_CHAN
> & 7) + 1;
> Â		pdata->nr_masters = (dw_params >> DW_PARAMS_NR_MASTER
> & 3) + 1;
> @@ -1477,8 +1489,6 @@ int dw_dma_probe(struct dw_dma_chip *chip)
> Â		pdata->block_size = dma_readl(dw, MAX_BLK_SIZE);
> Â
> Â		/* Fill platform data with the default values */
> -		pdata->is_private = true;
> -		pdata->is_memcpy = true;
> Â		pdata->chan_allocation_order =
> CHAN_ALLOCATION_ASCENDING;
> Â		pdata->chan_priority = CHAN_PRIORITY_ASCENDING;

...like

/* Apply platform defined quirks */
if (chip->data && chip->data->only_quirks_used) {
 ...
}


> -	if (of_property_read_u32(np, "dma-channels", &nr_channels))
> -		return NULL;
> +	if (device_property_read_bool(dev, "is-private"))

As I mentioned above, please do a separate patch for this.

> @@ -183,7 +186,7 @@ static int dw_probe(struct platform_device *pdev)
> Â
> Â	pdata = dev_get_platdata(dev);
> Â	if (!pdata)
> -		pdata = dw_dma_parse_dt(pdev);
> +		pdata = dw_dma_parse_dt(dev);

Perhaps you might rename the function to something like

dw_dma_parse_properties(dev);

> + * @only_quirks_used: Only read quirks (like "is_private" or
> "is_memcpy") from
> + *	platform data structure. Read other parameters from device
> tree
> + *	node (if exists) or from hardware autoconfig registers.

Can you somehow be more clear that all listed quirks will be copied from
platform data.

> Â * @is_nollp: The device channels does not support multi block
> transfers.
> Â * @chan_allocation_order: Allocate channels starting from 0 or 7
> Â * @chan_priority: Set channel priority increasing from 0 to 7 or 7
> to 0.
> @@ -52,6 +55,7 @@ struct dw_dma_platform_data {
> Â	unsigned int	nr_channels;
> Â	bool		is_private;
> Â	bool		is_memcpy;

> +	bool		only_quirks_used;

Perhaps add if at the end of quirk list and name justÂ

> Â	bool		is_nollp;

...here

bool use_quirks;

> Â#define CHAN_ALLOCATION_ASCENDING	0	/* zero to seven */
> Â#define CHAN_ALLOCATION_DESCENDING	1	/* seven to zero
> */

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy