Re: [PATCH] coding-style: fix mismatch of jump label name
From: Jean Delvare
Date: Wed Nov 02 2016 - 15:26:51 EST
Hi Masahiro-san,
On Thu, 3 Nov 2016 01:57:34 +0900, Masahiro Yamada wrote:
> Commit 865a1caa4b6b ("CodingStyle: Clarify and complete chapter 7")
> renamed the label "out_buffer" to "out_free_buffer", but missed to
> change this line.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
>
> Note:
> This patch is based on linux-next.
> The Documentation/CodingStyle was moved to
> Documentation/process/coding-style.rst
>
> Documentation/process/coding-style.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index 968808be..3e79051 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -475,7 +475,7 @@ The rationale for using gotos is:
> ...
> }
> result = 1;
> - goto out_buffer;
> + goto out_free_buffer;
> }
> ...
> out_free_buffer:
Oops, my bad. Good catch.
Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>
Feel free to add a Fixes: tag, although I doubt this kind of
documentation patch is often backported, so it probably doesn't really
matter.
Thanks,
--
Jean Delvare
SUSE L3 Support