Re: [RESEND PATCH V3 4/4] gpio: pv88080: Add GPIO function support

[Linus Walleij]

On Tue, Dec 6, 2016 at 6:33 AM, Eric Jeong
<eric.jeong.opensource@xxxxxxxxxxx> wrote:

> From: Eric Jeong <eric.jeong.opensource@xxxxxxxxxxx>
>
> This patch adds support for PV88080 PMIC GPIOs.
> PV88080 has two configurable GPIOs.
>
> Kconfig and Makefile are updated to reflect support
> for PV88080 PMIC GPIO.
>
> Signed-off-by: Eric Jeong <eric.jeong.opensource@xxxxxxxxxxx>

> +#include <linux/gpio.h>

Use

#include <linux/gpio/driver.h>

only.

> +#include <linux/mfd/pv88080.h>

I see this header is not yet upstream so I can't merge
this driver (else I would just correct the above and merge it).

With the oneliner change:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

I guess Lee needs to merge this with the MFD bits.

Yours,
Linus Walleij