Re: [PATCH v8 3/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature

[H. Nikolaus Schaller]

Hi Dmitry,

> Am 27.12.2016 um 22:54 schrieb Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>:
> 
> On Mon, Dec 12, 2016 at 10:21:25PM +0100, H. Nikolaus Schaller wrote:
>> Hi,
>> 
>> 
>>> Am 27.11.2016 um 16:47 schrieb H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>:
>>> 
>>> Hi Jonathan,
>>> 
>>>> Am 27.11.2016 um 12:02 schrieb Jonathan Cameron <jic23@xxxxxxxxxx>:
>>>> 
>>>> On 24/11/16 18:05, H. Nikolaus Schaller wrote:
>>>>> 
>>>>>> Am 24.11.2016 um 18:38 schrieb Jonathan Cameron <jic23@xxxxxxxxxxxxxxxxxxxxx>:
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> On 22 November 2016 14:02:30 GMT+00:00, "H. Nikolaus Schaller" <hns@xxxxxxxxxxxxx> wrote:
>> 
>>> 
>>>> - hence cc'd Yann and the Kbuild list
>>>> to see if they can offer some advices.
>> 
>> no response / advice so far.
> 
> Since you are saying that IIO stuff is optional, add it to Kconfig
> explicitly:
> 
> config "TOUCHSCREEN_TSC2007_IIO"
> 	bool "IIO interface for external ADC input and temperature"
> 	depends on TOUCHSCREEN_TSC2007
> 	depends on IIO=y || IIO=TOUCHSCREEN_TSC2007
> 	help
> 	  ...
> 
> and use this symbols in makefile:
> 
> and in Makefile:
> 
> obj-$(CONFIG_TOUCHSCREEN_TSC2007) += tsc2007.o
> tsc2007-y := tsc2007-core.o ...
> tsc2007-$(CONFIG_TOUCHSCREEN_TSC2007_IIO) += tsc2007_iio.o

Ah, ok. Well, we tried to make it without an explicit config option
but it does not hurt to have one.

Your proposal works fine for 3 out of the 4 possible combinations.

I think it is unlikely that the combination TOUCHSCREEN_TSC2007=y IIO=m
is needed at all (we configure as much as possible as =m in our kernel).

Patch v9 will come next (where I have also moved this iio driver
patch to be 8/8).

BR and thanks,
Nikolaus