RE: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe

[Kweh, Hock Leong]

> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@xxxxxxxxx]
> Sent: Thursday, December 29, 2016 2:43 AM
> To: Kweh, Hock Leong <hock.leong.kweh@xxxxxxxxx>; David Miller
> <davem@xxxxxxxxxxxxx>
> Cc: Joao.Pinto@xxxxxxxxxxxx; peppe.cavallaro@xxxxxx;
> seraphin.bonnaffe@xxxxxx; alexandre.torgue@xxxxxxxxx;
> manabian@xxxxxxxxx; niklas.cassel@xxxxxxxx; johan@xxxxxxxxxx;
> pavel@xxxxxx; Ong, Boon Leong <boon.leong.ong@xxxxxxxxx>; Voon, Weifeng
> <weifeng.voon@xxxxxxxxx>; lars.persson@xxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and
> stmmac_dvr_probe
> 
> On 12/27/2016 09:49 PM, Kweh, Hock Leong wrote:
> >> -----Original Message-----
> >> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> >> Sent: Wednesday, December 28, 2016 12:34 AM
> >> To: Kweh, Hock Leong <hock.leong.kweh@xxxxxxxxx>
> >> Cc: Joao.Pinto@xxxxxxxxxxxx; peppe.cavallaro@xxxxxx;
> >> seraphin.bonnaffe@xxxxxx; f.fainelli@xxxxxxxxx;
> >> alexandre.torgue@xxxxxxxxx; manabian@xxxxxxxxx;
> >> niklas.cassel@xxxxxxxx; johan@xxxxxxxxxx; pavel@xxxxxx; Ong, Boon
> >> Leong <boon.leong.ong@xxxxxxxxx>; Voon, Weifeng
> >> <weifeng.voon@xxxxxxxxx>; lars.persson@xxxxxxxx;
> >> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> >> Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize
> >> stmmac_open and stmmac_dvr_probe
> >>
> >> From: "Kweh, Hock Leong"	<hock.leong.kweh@xxxxxxxxx>
> >> Date: Tue, 27 Dec 2016 22:42:36 +0800
> >>
> >>> From: "Kweh, Hock Leong" <hock.leong.kweh@xxxxxxxxx>
> >>
> >> You are not the author of this change, do not take credit for it.
> >>
> >> You have copied Florian's patch character by character, therefore he
> >> is the author.
> >>
> >> You also didn't CC: the netdev mailing list properly.
> >
> > Hi David & Florian,
> >
> > Just to clarify that I do not copy exactly from Florian.
> > I have changed it to have proper handling on mdio unregister while
> > netdev_register() failed as showed below:
> >
> > 	return 0;
> >
> > -error_mdio_register:
> > -	unregister_netdev(ndev);
> >  error_netdev_register:
> > +	stmmac_mdio_unregister(ndev);
> 
> Although this is required, we can't be doing it in all circumstances, we need to
> mimic what stmmac_drv_remove() does.
> 
> Let me submit an incremental fix which takes care of mdio bus unregistration.
> --
> Florian

Noted & Thanks. Will test it out once you submitted.

Thanks & Regards,
Wilson