[PATCH] mm/filemap: fix parameters to test_bit()
From: Olof Johansson
Date: Thu Dec 29 2016 - 17:16:20 EST
mm/filemap.c: In function 'clear_bit_unlock_is_negative_byte':
mm/filemap.c:933:9: error: too few arguments to function 'test_bit'
return test_bit(PG_waiters);
^~~~~~~~
In file included from arch/arm/include/asm/bitops.h:122:0,
from include/linux/bitops.h:36,
from include/linux/kernel.h:10,
from include/linux/list.h:8,
from include/linux/wait.h:6,
from include/linux/fs.h:5,
from lude/linux/dax.h:4,
from mm/filemap.c:14:
include/asm-generic/bitops/non-atomic.h:103:19: note: declared here
static inline int test_bit(int nr, const volatile unsigned long *addr)
^~~~~~~~
mm/filemap.c:934:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
scripts/Makefile.build:293: recipe for target 'mm/filemap.o' failed
Fixes: b91e1302ad9b ('mm: optimize PageWaiters bit use for unlock_page()')
Signed-off-by: Olof Johansson <olof@xxxxxxxxx>
---
mm/filemap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 6b1d96f..d0e4d10 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -930,7 +930,7 @@ static inline bool clear_bit_unlock_is_negative_byte(long nr, volatile void *mem
{
clear_bit_unlock(nr, mem);
/* smp_mb__after_atomic(); */
- return test_bit(PG_waiters);
+ return test_bit(PG_waiters, mem);
}
#endif
--
2.8.0.rc3.29.gb552ff8