Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint

[Michal Hocko]

On Sat 31-12-16 01:04:56, Minchan Kim wrote:
[...]
> > From 5f1bc22ad1e54050b4da3228d68945e70342ebb6 Mon Sep 17 00:00:00 2001
> > From: Michal Hocko <mhocko@xxxxxxxx>
> > Date: Tue, 27 Dec 2016 13:18:20 +0100
> > Subject: [PATCH] mm, vmscan: add active list aging tracepoint
> > 
> > Our reclaim process has several tracepoints to tell us more about how
> > things are progressing. We are, however, missing a tracepoint to track
> > active list aging. Introduce mm_vmscan_lru_shrink_active which reports
> 
> I agree this part.
> 
> > the number of
> > 	- nr_scanned, nr_taken pages to tell us the LRU isolation
> > 	  effectiveness.
> 
> I agree nr_taken for knowing shrinking effectiveness but don't
> agree nr_scanned. If we want to know LRU isolation effectiveness
> with nr_scanned and nr_taken, isolate_lru_pages will do.

Yes it will. On the other hand the number is there and there is no
additional overhead, maintenance or otherwise, to provide that number.
The inactive counterpart does that for quite some time already. So why
exactly does that matter? Don't take me wrong but isn't this more on a
nit picking side than necessary? Or do I just misunderstand your
concenrs? It is not like we are providing a stable user API as the
tracepoint is clearly implementation specific and not something to be
used for anything other than debugging.

> > 	- nr_rotated pages which tells us that we are hitting referenced
> > 	  pages which are deactivated. If this is a large part of the
> > 	  reported nr_deactivated pages then the active list is too small
> 
> It might be but not exactly. If your goal is to know LRU size, it can be
> done in get_scan_count. I tend to agree LRU size is helpful for
> performance analysis because decreased LRU size signals memory shortage
> then performance drop.

No, I am not really interested in the exact size but rather to allow to
find whether we are aging the active list too early...

> 
> > 	- nr_activated pages which tells us how many pages are keept on the
>                                                                kept

fixed

> 
> > 	  active list - mostly exec pages. A high number can indicate
> 
>                                file-based exec pages

OK, fixed

> 
> > 	  that we might be trashing on executables.
> 
> And welcome to drop nr_unevictable, nr_freed.
> 
> I will be off until next week monday so please understand if my response
> is slow.

There is no reason to hurry...
-- 
Michal Hocko
SUSE Labs