Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk

[Mathias Nyman]

On 03.01.2017 14:53, Felipe Balbi wrote:
> Hi,
>
> Roger Quadros <rogerq@xxxxxx> writes:
> > Mathias & Felipe,
> >
> > On 17/11/16 17:01, Roger Quadros wrote:
> > > Hi,
> > >
> > > Some XHCI controllers e.g. dwc3 based have a broken Port disable [1].
> > >
> > > If the attached high-speed device is misbehaving, the USB stack typically
> > > disables the port using the PED bit in PORTSC. For the controllers that
> > > have broken port disable, the port fails to detect further attach/detach
> > > events and so high-speed devices can no longer be enumerated on the
> > > port. The workaround is to prevent port disable using PED on such
> > > controllers.
> > >
> > > We add a new BROKEN_PED quirk flag and 'quirk-broken-port-ped' device
> > > property and prevent port disable using PED if we encounter the quirk flag.
> > >
> > > [1] - AM572x Silicon Errata http://www.ti.com/lit/er/sprz429j/sprz429j.pdf
> > >      Section i896â USB xHCI Port Disable Feature Does Not Work
> >
> > Any comments on this series?
> > patch 1 is at v3. Rest 2 are original.
>
> none from me. Mathias?

Looks good to me, I'll add them to the queue

-Mathias