Re: [PATCH] x86/mce: Fix initialization error warning

From: Thomas Gleixner
Date: Tue Jan 17 2017 - 04:10:24 EST


On Tue, 17 Jan 2017, Borislav Petkov wrote:
> On Tue, Jan 17, 2017 at 09:34:18AM +0100, Thomas Gleixner wrote:
> > That's one thing, but OTOH we really can avoid the KERN_ERR level print out
> > for the case where mce is not available (for whatever reasons: HW / Virt /
> > command line ....).
> >
> > The simple 2 liner I posted earlier in this thread does it nicely.
>
> Well, I seem to remember at the time of this:
>
> 9c15a24b038f ("x86/mce: Improve mcheck_init_device() error handling")
>
> that I requested to have that error message there so that we *know* when
> that function fails instead of trying to decipher "Hey, mcelog doesn't
> start here" and wonder why.
>
> But we can kill it just as well, especially as there's patch deprecating
> /dev/mcelog floating around. We can reorg error messages in that
> function later, if deemed necessary.

Your decision.