Re: [PATCH v3] dt-bindings: power: supply: bq24735: reverse the polarity of ac-detect
From: Paul Kocialkowski
Date: Tue Jan 24 2017 - 11:26:42 EST
Le jeudi 15 dÃcembre 2016 Ã 18:50 +0100, Peter Rosin a ÃcritÂ:
> The bindings are fine.
> The Tegra dts files are buggy, but the driver is also buggy, so those
> two bugs cancel each other. So, the option is to either introduce
> regressions by fixing the two bugs thus creating a flag day where
> the kernel and dt needs to match. Or, just document what is going on
> and change the bindings even if they are not wrong.
After reading the discussion, I would rather be in favor of fixing the driver
and the tegra dts files, which are both wrong.
Keeping things as-is is very counter-intuitive: the GPIO on nyan boards is
active-low and should be described as such (think of other projects, like
U-Boot, reusing the dts). It's also very counter-intuitive to require that any
new board using that driver use active-low polarity in the GPIO declaration when
the line is really active-high.
So yes, it means that older dtbs won't work with new kernels and vice-versa, but
as it was pointed out, this is a bug fix, not even a cosmetic change.
Is anyone strongly opposed to that solution? I'd really rather see the issue
fixed that way instead of the current proposal (this patch).
I'd also be happy to implement and test that solution on nyans, as I've done
other bq24735-related work for nyans recently.
Paul Kocialkowski, developer of free digital technology at the lower levels
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
Description: This is a digitally signed message part