Re: [PATCH v3] dt-bindings: power: supply: bq24735: reverse the polarity of ac-detect
From: Peter Rosin
Date: Wed Jan 25 2017 - 07:20:45 EST
On 2017-01-24 17:24, Paul Kocialkowski wrote:
> Le jeudi 15 dÃcembre 2016 Ã 18:50 +0100, Peter Rosin a Ãcrit :
>> The bindings are fine.
>> The Tegra dts files are buggy, but the driver is also buggy, so those
>> two bugs cancel each other. So, the option is to either introduce
>> regressions by fixing the two bugs thus creating a flag day where
>> the kernel and dt needs to match. Or, just document what is going on
>> and change the bindings even if they are not wrong.
> After reading the discussion, I would rather be in favor of fixing the driver
> and the tegra dts files, which are both wrong.
> Keeping things as-is is very counter-intuitive: the GPIO on nyan boards is
> active-low and should be described as such (think of other projects, like
> U-Boot, reusing the dts). It's also very counter-intuitive to require that any
> new board using that driver use active-low polarity in the GPIO declaration when
> the line is really active-high.
Agreed, it very counter-intuitive. I have a board w/o an invert and it
does look odd with active-low in the dts. It really should be active-high.
The (new) binding helps a bit though.
But that said, for various reasons I ended up not using that binding anyway
and instead rely on polling the internal register for the ACOK bit.
> So yes, it means that older dtbs won't work with new kernels and vice-versa, but
> as it was pointed out, this is a bug fix, not even a cosmetic change.
> Is anyone strongly opposed to that solution? I'd really rather see the issue
> fixed that way instead of the current proposal (this patch).
It's a little bit more than a proposal since it is in linux-next. But not set
in stone of course. I personally do not care as long as it is changed before
hitting Linus' tree as I have no deployed devices. But docs are just that.
Docs. Anything that worked before is going to break with the change you are
proposing. Are you really willing to break who knows how many tegra boards?
What will you do a few months down the line when the regression reports start
to creep in??? Argue about it with Linus? And then revert and create an even
bigger mess? You could skip the arguing step and revert right away, but how
is that helpful?
Or do you somehow know that *all* tegra users will always update their kernel
and dtb in sync, so that regressions will not happen?
> I'd also be happy to implement and test that solution on nyans, as I've done
> other bq24735-related work for nyans recently.
Changing this is trivial. Testing that the change does what it is supposed to
is not the main obstacle...