Re: [PATCH v4 3/3] p54: convert to sysdata API
From: Linus Torvalds
Date: Fri Jan 27 2017 - 15:54:29 EST
On Fri, Jan 27, 2017 at 10:23 AM, Luis R. Rodriguez <mcgrof@xxxxxxxxxx> wrote:
>> So I'm really not seeing why you want to make these conversions that
>> just make code worse.
> The real goal here was first to actually provide a flexible API to enable
> more advanced features to be added without having to affect existing
> callers, as has been done before.
So I've said this before, and I'll say this one more time:
It's fine if we make the internal implementation of some generic "load
data from the filesystem or user" be this kind of new flexible API
that is internally called "driver_data_request()" or whatever.
But dammit, that is NOT AN EXCUSE for then making crap patches that
just replace the existing firmware users.
If the new interface cannot be wrapped in the old names (and the old
semantics) the new interface is shit and should never ever go
So leave the existing users alone. Concentrate on _only_ the parts
where there is actual and real need of new features. Don't try to
rename or extend current drivers. Don't send out these patches that
make drivers actively uglier. Really.
I really question the whole thing when there are things like this going on.