Re: [PATCH 4/5] xen, x86/headers: Add <linux/device.h> dependency to <asm/xen/page.h>

[Juergen Gross]

On 01/02/17 10:51, Ingo Molnar wrote:
> The following patch (not upstream yet):
> 
>   "x86/boot/e820: Remove spurious asm/e820/api.h inclusions"
> 
> Removed the (spurious) <asm/e820.h> include line from <asm/pgtable.h> to
> reduce header file dependencies - but a Xen header has (unintentionally)
> learned to rely on the indirect inclusion of <linux/device.h>.
> 
> This resulted in the following (harmless) build warning:
> 
>    arch/x86/include/asm/xen/page.h:302:7: warning: 'struct device' declared inside parameter list
> 
> Include <linux/device.h> explicitly.
> 
> No change in functionality.
> 
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Cc: <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Juergen Gross <jgross@xxxxxxxx>

Hmm, how did you send this? In spite of the Cc: list in the patch only
few of those listed here are included in the Cc: header of the mail.

> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>

Acked-by: Juergen Gross <jgross@xxxxxxxx>


Juergen