Re: [PATCH 1/3] arc: vdk: Disable halt on reset
From: Alexey Brodkin
Date: Wed Feb 01 2017 - 12:14:17 EST
Hi Vineet,
On Wed, 2017-02-01 at 08:52 -0800, Vineet Gupta wrote:
> On 02/01/2017 08:42 AM, Alexey Brodkin wrote:
> >
> > In recent VDKs ARC cores are configured as "run on reset"
> > which made existing kernel configuration outdated to effect that
> > slave cores never start execution of the code keeping only master
> > online.
> >
> > With that fix we're again in sync with VDK platform.
> >
> > And while at it we regenerate defconfig via savedefconfig so default
> > options are now excluded.
> >
> > Signed-off-by: Alexey Brodkin <abrodkin@xxxxxxxxxxxx>
> > ---
> > Âarch/arc/configs/vdk_hs38_smp_defconfig | 4 +---
> > Â1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/arch/arc/configs/vdk_hs38_smp_defconfig b/arch/arc/configs/vdk_hs38_smp_defconfig
> > index 573028f19de7..f6361de41eec 100644
> > --- a/arch/arc/configs/vdk_hs38_smp_defconfig
> > +++ b/arch/arc/configs/vdk_hs38_smp_defconfig
> > @@ -15,7 +15,7 @@ CONFIG_ARC_PLAT_AXS10X=y
> > ÂCONFIG_AXS103=y
> > ÂCONFIG_ISA_ARCV2=y
> > ÂCONFIG_SMP=y
> > -# CONFIG_ARC_TIMERS_64BIT is not set
>
> Are you sure abut this part. Ater the timers driver rework, this would enable GFRC
> for SMP builds and AFAIKR there were some issues with time with GFRC + nSIM etc..
Not anymore :)
Probably I missed something in discussions.
As a matter of fact I did run-test resulting vmlinux and it worked very nice.
More overÂARC_TIMERS_64BIT is selected automatically byÂISA_ARCV2, see
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arc/Kconfig#n119
That said even if "# CONFIG_ARC_TIMERS_64BIT is not set" is left in place the option will be
effectively enabled, no?
-Alexey