Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

[Eddie Cai]

Hi Andrew

2017-02-06 10:54 GMT+08:00 Andrew Lunn <andrew@xxxxxxx>:
> Hi Eddie
>
>> +             button@0 {
>> +                     gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
>> +                     linux,code = <116>;
>
> It is a good idea to use include/dt-bindings/input/input.h
>
> and then you can replace <116> with < KEY_POWER > which is more
> readable.
Thanks, I will modify it in next version.
>
>> +                     label = "GPIO Key Power";
>> +                     linux,input-type = <1>;
>
> < EV_KEY >
>
>> +                     gpio-key,wakeup = <1>;
>
> This has been replace with wakeup-source.
Thanks, I will modify it in next version
>
>> +                     debounce-interval = <100>;
>> +             };
>> +     };
>
>   Andrew